Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing arguments, use typehint #162

Merged
merged 15 commits into from
Jun 18, 2024
Merged

Fix parsing arguments, use typehint #162

merged 15 commits into from
Jun 18, 2024

Conversation

bjartek
Copy link
Owner

@bjartek bjartek commented Jun 3, 2024 •
edited
Loading

Closes #121

Description

For contributor use:

  • Targeted PR against main branch
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Test Results

191 tests  ±0   191 ✔️ ±0   27s ⏱️ ±0s
    3 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8c7fbc2. ± Comparison against base commit b089c0f.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Jun 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9561721053

Details

  • 56 of 62 (90.32%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 76.001%
Changes Missing Coverage Covered Lines Changed/Added Lines %
result.go 0 1 0.0%
state.go 36 41 87.8%
Files with Coverage Reduction New Missed Lines %
state.go 2 80.82%
Totals Coverage Status
Change from base Build 8993174337: -0.1%
Covered Lines: 2106
Relevant Lines: 2771
💛 - Coveralls

@bjartek bjartek changed the title Gabriel Fix parsing arguments, use typehint Jun 11, 2024
@bjartek bjartek self-assigned this Jun 11, 2024
@bjartek bjartek requested a review from willsu88 June 11, 2024 09:54
@bjartek bjartek mentioned this pull request Jun 13, 2024
Closed
willsu88
willsu88 reviewed Jun 14, 2024
View reviewed changes
state.go Outdated Show resolved Hide resolved
state.go Show resolved Hide resolved
gabrielseibel1
gabrielseibel1 reviewed Jun 14, 2024
View reviewed changes
state.go Outdated Show resolved Hide resolved
willsu88
willsu88 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@willsu88 willsu88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on my end. i'll leave to @gabrielseibel1 to see if he has any other comments he wants to resolve or mention

gabrielseibel1
gabrielseibel1 approved these changes Jun 17, 2024
View reviewed changes
state.go Outdated Show resolved Hide resolved
@bjartek bjartek merged commit c54f5f1 into main Jun 18, 2024
4 of 5 checks passed
@bjartek bjartek deleted the gabriel branch June 18, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielseibel1 gabrielseibel1 gabrielseibel1 approved these changes

@willsu88 willsu88 willsu88 approved these changes

Assignees

@bjartek bjartek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when parsing argument
4 participants
@bjartek @coveralls @gabrielseibel1 @willsu88